Patch python_full_version unconditionally #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
force-pushed
the
bugfix/678-python-full-version-untagged
branch
2 times, most recently
from
46a2d24 to
cc7c168
Compare
jaraco
force-pushed
the
bugfix/678-python-full-version-untagged
branch
from
cc7c168 to
540fe8d
Compare
Indeed, this change won't affect those failures, because they're related to I'm somewhat disinterested in solving the larger issue, given that I was happy with distutils' lenient version objects. |
brettcannon
approved these changes
Aug 27, 2024
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jan 30, 2025
Fix a long-standing bug handling development versions of CPython (any non-tagged release of the interpreter). These interpreters report a full version of `X.Y.Z+` and the trailing `+` leads to a non PEP-440 compliant version number. This, in turn, causes issues with the `packaging` library leading to failures to evaluate markers for these interpreters which surface as inscrutable Pex errors. Apply the same workaround as used in packaging >= 24.1. See: + pypa/packaging#802 + pypa/packaging#825
jsirois
added a commit
to pex-tool/pex
that referenced
this pull request
Jan 30, 2025
Fix a long-standing bug handling development versions of CPython (any non-tagged release of the interpreter). These interpreters report a full version of `X.Y.Z+` and the trailing `+` leads to a non PEP-440 compliant version number. This, in turn, causes issues with the `packaging` library leading to failures to evaluate markers for these interpreters which surface as inscrutable Pex errors. Apply the same workaround as used in packaging >= 24.1. See: + pypa/packaging#802 + pypa/packaging#825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #678 . Reprise of #802.